fix: replace shell-quote with literal arg splitter to handle # in claude_args values#982
Open
Mellowambience wants to merge 1 commit intoanthropics:mainfrom
Open
Conversation
Fixes anthropics#980 shell-quote's parse() treats # as a shell comment character, returning a {comment: '...'} object. The .filter(arg => typeof arg === 'string') call drops this, leaving the preceding flag with no value. The parser then sets that flag to null, which fails AJV schema validation and crashes the action. Replacement: splitArgString() splits on whitespace, respects double-quoted strings, and never interprets shell metacharacters. claude_args is a list of CLI flags, not a shell command — # should never be treated as a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #980
Problem
shell-quote'sparse()treats#as a shell comment character, returning a{comment: "..."}object instead of a string. The.filter(arg => typeof arg === "string")call drops this object, leaving the preceding flag with no value. The parser then sets that flag tonull, which fails AJV schema validation and crashes the action before any API call is made.Reproduction:
→
append-system-prompt: null→ AJV validation crashSolution
Replace
shell-quotewith a purpose-builtsplitArgString()that:#,!,~,$are all treated as literal charactersclaude_argsis a list of CLI flags, not a shell command. There's no reason for#to be interpreted as a comment.Changes
base-action/src/parse-sdk-options.ts: AddsplitArgString(), replaceparseShellArgs(claudeArgs).filter(...)withsplitArgString(claudeArgs)Workaround for users (until merged)
Double-quote values containing
#:Testing
Manually verified against the reproduction case. Happy to add unit tests to the test suite if you can point me to the right test file — I see
__tests__/referenced but wasn't sure of the exact conventions here.