C#: Only use reachable feeds when private registries are configured#21385
Open
C#: Only use reachable feeds when private registries are configured#21385
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the NuGet feed reachability checking logic in C# dependency fetching to support scenarios where customers only have access to private registries and not to public feeds like NuGet.org. The core change is to check both explicit and inherited feeds for reachability, and only pass reachable feeds to dotnet restore.
Changes:
- Refactored feed reachability checking to test both explicit feeds (from nuget.config files in the working directory and dependabot proxy) and inherited feeds (from nuget.config files outside the working directory)
- Modified
RestoreProjectsto receive only reachable feeds instead of all configured feeds - Extracted common feed reachability logic into a new
GetReachableNuGetFeedsmethod to reduce code duplication
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs
Show resolved
Hide resolved
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs
Show resolved
Hide resolved
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some customers only allow access to their own private registries and do not allow access to e.g. the public NuGet feed. This PR refactors and modifies the
build-mode: nonelogic that tests whether feeds are reachable to also check the inherited feeds, and to only pass explicit and inherited feeds which are reachable todotnet restore.