Use /p:RestoreIgnoreFailedSources=true for dotnet restore#21386
Open
Use /p:RestoreIgnoreFailedSources=true for dotnet restore#21386
/p:RestoreIgnoreFailedSources=true for dotnet restore#21386Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the /p:RestoreIgnoreFailedSources=true option to all dotnet restore commands in the C# extractor to improve performance when multiple NuGet feeds are configured and some are consistently unreachable.
Changes:
- Added
/p:RestoreIgnoreFailedSources=trueflag to theGetRestoreArgsmethod in the DotNet utility class - Updated all 5 related unit tests to verify the new command structure includes the flag
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DotNet.cs | Added the /p:RestoreIgnoreFailedSources=true flag to the restore command arguments |
| csharp/extractor/Semmle.Extraction.Tests/DotNet.cs | Updated 5 test assertions to include the new flag in the expected command strings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet restoretends to take a very long time to run if there are multiple NuGet feeds and some of them are consistently not reachable. As an experiment (suggested by @michaelnebel), this PR adds the/p:RestoreIgnoreFailedSources=trueoption when we calldotnet restorein the BMN extractor.