test: skip test-url on --shared-ada builds#62019
Conversation
|
Review requested:
|
|
I think we do have the machinery elsewhere already that would allow this to not blanket skip everything Lines 420 to 439 in 7cf2dad node/test/wpt/status/console.json Line 4 in 7cf2dad Furthermore the status files can be .cjs for setting expectations for individual tests dynamically. |
dc04ab6 to
5145814
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62019 +/- ##
==========================================
- Coverage 89.74% 89.72% -0.02%
==========================================
Files 676 676
Lines 206072 206069 -3
Branches 39507 39514 +7
==========================================
- Hits 184936 184902 -34
- Misses 13303 13310 +7
- Partials 7833 7857 +24 🚀 New features to boost your workflow:
|
That's true, but tbh that seems hardly worth the maintenance burden, each version of Ada will pass a different subset of the tests. I've removed the |
test-url on --without-intl and --shared-ada buildstest-url on --shared-ada builds
|
Ok, if this is limited to shared ada ✅ |
No description provided.