test: remove unnecessary process.exit calls from test files#62020
Open
aduh95 wants to merge 2 commits intonodejs:mainfrom
Open
test: remove unnecessary process.exit calls from test files#62020aduh95 wants to merge 2 commits intonodejs:mainfrom
process.exit calls from test files#62020aduh95 wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
benchmark
JakobJingleheimer
approved these changes
Feb 27, 2026
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
juliangruber
approved these changes
Feb 27, 2026
targos
approved these changes
Feb 27, 2026
Renegade334
reviewed
Feb 27, 2026
Comment on lines
52
to
53
| } else if (common.isAIX) { | ||
| console.log('1..0 # Skipped: test runner without specifying files fails on AIX'); |
Member
There was a problem hiding this comment.
Looks like this should also be a skip.
Comment on lines
8
to
10
| if (common.hasCrypto) { | ||
| console.log('1..0 # Skipped: no crypto'); | ||
| process.exit(0); | ||
| common.skip('no crypto'); | ||
| } |
Member
There was a problem hiding this comment.
@mcollina do you remember the context for this? I can't tell why crypto has any influence on this test, and the logic also appears the wrong way round?
Contributor
Author
There was a problem hiding this comment.
I've opened #62026 to investigate. It looks like the test runner attempts to open the .so files when building with shared OpenSSL, which would be a bug
Member
There was a problem hiding this comment.
With shared OpenSSL, the OpenSSL libraries need to be on the library path (LD_LIBRARY_PATH on Linux) for the node binary to run.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62020 +/- ##
==========================================
- Coverage 89.74% 89.73% -0.01%
==========================================
Files 676 676
Lines 206072 206069 -3
Branches 39507 39524 +17
==========================================
- Hits 184936 184923 -13
- Misses 13303 13319 +16
+ Partials 7833 7827 -6 🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Feb 27, 2026
Collaborator
pmarchini
approved these changes
Feb 27, 2026
lpinca
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a bunch of calls that do nothing, this PR removes those to make the tests more readable